[PATCH] [libcxx] Cleanup the cleanup of temporary files.

Dan Albert danalbert at google.com
Mon Jan 5 15:13:28 PST 2015


================
Comment at: test/lit.cfg:135
@@ +134,3 @@
+        res = self._evaluate_test(test, use_verify, lit_config)
+        self._clean()
+        return res
----------------
EricWF wrote:
> mclow.lists wrote:
> > Can `self._evaluate_test` throw?
> > 
> > If so, you'll skip the call to `_clean`.
> > On the other hand, `_clean` appears to be empty now.
> I would like @danalbert to comment on this. I think he uses _clean() in the android configuration.
`_clean()` should be thought of as a virtual method. It needs to be overridden for remote execution because the steps taken to clean up remote workspaces will vary.

http://reviews.llvm.org/D6739

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list