[PATCH] [libcxx] Cleanup the cleanup of temporary files.

Marshall Clow mclow.lists at gmail.com
Sat Dec 20 09:44:40 PST 2014


This looks reasonable to me.


================
Comment at: test/lit.cfg:135
@@ +134,3 @@
+        res = self._evaluate_test(test, use_verify, lit_config)
+        self._clean()
+        return res
----------------
Can `self._evaluate_test` throw?

If so, you'll skip the call to `_clean`.
On the other hand, `_clean` appears to be empty now.

http://reviews.llvm.org/D6739

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list