[PATCH] Insert random NOPs to increase security against ROP attacks (clang)

JF Bastien jfb at chromium.org
Fri Dec 19 15:32:48 PST 2014


Can you update the description to use "noop" instead of "nop"? I don't really care either way, but it should be consistent with the code.

It also looks like this patch only passes `-noop-insertion` to LLVM, not the other 2?

I recommend seeking an LGTM from a person more familiar with clang that I am. This looks OK to my untrained eye, but I'd not at all familiar with clang's code base.


http://reviews.llvm.org/D3393

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list