r224595 - Added a fixit to remove empty parens from a C++11 attribute argument list when we diagnose this as an error.

Aaron Ballman aaron at aaronballman.com
Fri Dec 19 10:37:22 PST 2014


Author: aaronballman
Date: Fri Dec 19 12:37:22 2014
New Revision: 224595

URL: http://llvm.org/viewvc/llvm-project?rev=224595&view=rev
Log:
Added a fixit to remove empty parens from a C++11 attribute argument list when we diagnose this as an error.

Added:
    cfe/trunk/test/SemaCXX/attr-cxx0x-fixit.cpp
Modified:
    cfe/trunk/lib/Parse/ParseDeclCXX.cpp

Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Parse/ParseDeclCXX.cpp?rev=224595&r1=224594&r2=224595&view=diff
==============================================================================
--- cfe/trunk/lib/Parse/ParseDeclCXX.cpp (original)
+++ cfe/trunk/lib/Parse/ParseDeclCXX.cpp Fri Dec 19 12:37:22 2014
@@ -3469,7 +3469,6 @@ bool Parser::ParseCXX11AttributeArgs(Ide
       if (Attr->getMaxArgs() && !NumArgs) {
         // The attribute was allowed to have arguments, but none were provided
         // even though the attribute parsed successfully. This is an error.
-        // FIXME: This is a good place for a fixit which removes the parens.
         Diag(LParenLoc, diag::err_attribute_requires_arguments) << AttrName;
         return false;
       } else if (!Attr->getMaxArgs()) {
@@ -3477,7 +3476,8 @@ bool Parser::ParseCXX11AttributeArgs(Ide
         // arguments. It doesn't matter whether any were provided -- the
         // presence of the argument list (even if empty) is diagnosed.
         Diag(LParenLoc, diag::err_cxx11_attribute_forbids_arguments)
-            << AttrName;
+            << AttrName
+            << FixItHint::CreateRemoval(SourceRange(LParenLoc, *EndLoc));
         return false;
       }
     }

Added: cfe/trunk/test/SemaCXX/attr-cxx0x-fixit.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/attr-cxx0x-fixit.cpp?rev=224595&view=auto
==============================================================================
--- cfe/trunk/test/SemaCXX/attr-cxx0x-fixit.cpp (added)
+++ cfe/trunk/test/SemaCXX/attr-cxx0x-fixit.cpp Fri Dec 19 12:37:22 2014
@@ -0,0 +1,5 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s
+// RUN: not %clang_cc1 -fsyntax-only -fdiagnostics-parseable-fixits -std=c++11 %s 2>&1 | FileCheck %s
+
+[[noreturn()]] void f(); // expected-error {{attribute 'noreturn' cannot have an argument list}} \
+// CHECK: fix-it:"{{.*}}":{4:11-4:13}:""





More information about the cfe-commits mailing list