[PATCH] [libcxxabi] Add __cxa_thread_atexit for TLS support on Linux.

Jonathan Roelofs jonathan at codesourcery.com
Wed Dec 17 11:57:37 PST 2014


================
Comment at: test/cxa_thread_atexit_test.cpp:15
@@ +14,3 @@
+
+extern "C" int __cxa_thread_atexit_impl(void (*dtor)(void *), void *obj,
+                                        void *dso_symbol) {
----------------
What about when the libc provides this symbol? Is it normally weak?

================
Comment at: test/cxa_thread_atexit_test.cpp:16
@@ +15,3 @@
+extern "C" int __cxa_thread_atexit_impl(void (*dtor)(void *), void *obj,
+                                        void *dso_symbol) {
+  assert(dtor == reinterpret_cast<void (*)(void *)>(1));
----------------
to have the same signature, this needs throw().

http://reviews.llvm.org/D6708

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list