[PATCH] Fix clash of gcc toolchains in driver regression tests

[Rafael Espíndola]

LGTM

On 3 October 2014 at 20:02, Samuel F Antao <sfantao at us.ibm.com> wrote:
> Ping!
>
> Thanks,
> Samuel
>
> 2014-09-11 9:49 GMT-04:00 Rafael Espíndola <rafael.espindola at gmail.com>:
>>
>> On 10 September 2014 19:02, Samuel F Antao <sfantao at us.ibm.com> wrote:
>> > Hi all,
>> >
>> > Some regression tests for the driver rely on the minimal/dummy system
>> > root
>> > that comes in the Inputs folder included in the clang driver tests’s
>> > folder.
>> > The path to the right toolchain is specified using the —sysroot switch.
>> > However, if clang was configured with a custom gcc toolchain (either by
>> > using GCC_INSTALL_PREFIX in cmake or the equivalent configure command),
>> > the
>> > path to the custom gcc toolchain path takes precedence to the one
>> > specified
>> > by sysroot. This causes several regression tests to fail as they will be
>> > using an unexpected path.
>> > This patch fixes this issue by adding --gcc-toolchain=“” to all tests
>> > that
>> > rely on that. The empty string causes the driver to pick the path from
>> > sysroot instead. There aren’t any changes in the driver’s code, only the
>> > tests are modified. The driver's regression tests for hexagon also have
>> > similar issues but these require modifications in the driver’s code.
>> > I’ll
>> > send these fixes in a separate patch.
>>
>> I think this is OK, but Chandler should probably have the final say.
>>
>> Cheers,
>> Rafael
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>