r224012 - Emit warning if define or undef reserved identifier or keyword.

Serge Pavlov sepavloff at gmail.com
Mon Dec 15 10:01:21 PST 2014


Maybe turn this warning off by default? As Nico pointed out, there are
additional cases:

#define inline _inline
#define final(a,b,c) some_computation(a, b,c )

They are not covered by the rules above.

Thanks,
--Serge

2014-12-15 23:45 GMT+06:00 Aaron Ballman <aaron at aaronballman.com>:
>
> On Mon, Dec 15, 2014 at 12:11 PM, Serge Pavlov <sepavloff at gmail.com>
> wrote:
> > 2014-12-15 22:32 GMT+06:00 Aaron Ballman <aaron at aaronballman.com>:
> >>
> >>
> >> This commit appears to be lacking tests, and I would like to see some
> >> added for each of the new diagnostics, as well as for cases that
> >> should be valid (such as keywords in language modes that do not have
> >> the keyword).
> >>
> >>
> > Test are added in r224100.
>
> So they are, thank you for pointing that out!
>
> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141216/fbb6c3b3/attachment.html>


More information about the cfe-commits mailing list