[PATCH] Pretty print template arg enum constants (if possible)

Richard Smith richard at metafoo.co.uk
Fri Dec 12 14:46:45 PST 2014


+  if (const EnumType* ET = dyn_cast<EnumType>(T)) {

* on the right please, and use T->getAs<EnumType>() in case there is type
sugar here (there probably can't be for a TemplateArgument that's been
resolved to an integral value, but dyn_cast on a type is a red flag that we
don't need here).

Otherwise, LGTM, thanks!

On Thu, Dec 11, 2014 at 8:28 PM, Will Wilson <will at indefiant.com> wrote:

> Hi Richard,
>
> Here's a simple patch that improves pretty printing for templates args
> specialized to enum constants. If an enum constant isn't available to
> represent the value it falls back on printing the integer value.
>
> Tested against latest trunk and includes a new test case and a updated
> existing test case.
>
> Let me know if it looks good to go...
>
> Cheers,
> Will.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141212/e919493e/attachment.html>


More information about the cfe-commits mailing list