[Patch] libc++: Add a default rune table

Joerg Sonnenberger joerg at britannica.bec.de
Thu Dec 11 06:15:17 PST 2014


On Thu, Dec 11, 2014 at 01:42:57PM +0100, Ed Schouten wrote:
> > Please properly use the system table, no need to waste space.
> 
> That would be the opposite of what we're trying to achieve. Please
> read up on the bug mentioned earlier in this discussion, which points
> out the problems with using the system table.

If the system doesn't provide a usable version, doing our own is fine.
But this is complete removing the support on systems that have usable
tables. That's a regression. A good start would splitting this into two
parts -- using a common function shared by the individual code point and
the range of code points logic. I don't think there is any contention
about doing that. I disagree with removing the working platform logic.

Joerg



More information about the cfe-commits mailing list