[Patch] libc++: Add a default rune table

Chandler Carruth chandlerc at google.com
Thu Dec 11 05:27:39 PST 2014


Generally speaking, I am strongly in favor of libc++ isolating its
functionality from features which are so varying in quality from system to
system as locales. Where it is reasonable from a maintenance and support
perspective, I would much rather than libc++ simple implement and provide
the desired behavior from first principles.

On Thu, Dec 11, 2014 at 2:17 PM, Yaron Keren <yaron.keren at gmail.com> wrote:

> Last time I looked, libc++ on Windows uses an undocumented table in
> MSVCRT.DLL for this purpose.
> It would be much better to use a built-in table.
>
>
> 2014-12-11 14:42 GMT+02:00 Ed Schouten <ed at 80386.nl>:
>
>> Hi Joerg,
>>
>> 2014-12-11 12:40 GMT+01:00 Joerg Sonnenberger <joerg at britannica.bec.de>:
>> >> +    return (c >= L'a' && c <= L'z') ? c - L'a' + L'A' : c;
>> >
>> > Regression?
>>
>> Could you please clarify?
>>
>> > Please properly use the system table, no need to waste space.
>>
>> That would be the opposite of what we're trying to achieve. Please
>> read up on the bug mentioned earlier in this discussion, which points
>> out the problems with using the system table.
>>
>> Thanks,
>> --
>> Ed Schouten <ed at 80386.nl>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141211/a92f7d1c/attachment.html>


More information about the cfe-commits mailing list