r223489 - Use else if when checking multiple attributes.

Matt Arsenault Matthew.Arsenault at amd.com
Fri Dec 5 10:03:55 PST 2014


Author: arsenm
Date: Fri Dec  5 12:03:55 2014
New Revision: 223489

URL: http://llvm.org/viewvc/llvm-project?rev=223489&view=rev
Log:
Use else if when checking multiple attributes.

Only one of these can really match.

Modified:
    cfe/trunk/lib/Sema/SemaDeclAttr.cpp

Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclAttr.cpp?rev=223489&r1=223488&r2=223489&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclAttr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclAttr.cpp Fri Dec  5 12:03:55 2014
@@ -4764,12 +4764,10 @@ void Sema::ProcessDeclAttributeList(Scop
     if (Attr *A = D->getAttr<ReqdWorkGroupSizeAttr>()) {
       Diag(D->getLocation(), diag::err_opencl_kernel_attr) << A;
       D->setInvalidDecl();
-    }
-    if (Attr *A = D->getAttr<WorkGroupSizeHintAttr>()) {
+    } else if (Attr *A = D->getAttr<WorkGroupSizeHintAttr>()) {
       Diag(D->getLocation(), diag::err_opencl_kernel_attr) << A;
       D->setInvalidDecl();
-    }
-    if (Attr *A = D->getAttr<VecTypeHintAttr>()) {
+    } else if (Attr *A = D->getAttr<VecTypeHintAttr>()) {
       Diag(D->getLocation(), diag::err_opencl_kernel_attr) << A;
       D->setInvalidDecl();
     }





More information about the cfe-commits mailing list