r223403 - Adding a FIXME to the code, based on a discussion in IRC; NFC.

Aaron Ballman aaron at aaronballman.com
Thu Dec 4 14:45:31 PST 2014


Author: aaronballman
Date: Thu Dec  4 16:45:31 2014
New Revision: 223403

URL: http://llvm.org/viewvc/llvm-project?rev=223403&view=rev
Log:
Adding a FIXME to the code, based on a discussion in IRC; NFC.

Modified:
    cfe/trunk/lib/Sema/SemaDeclAttr.cpp

Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclAttr.cpp?rev=223403&r1=223402&r2=223403&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclAttr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclAttr.cpp Thu Dec  4 16:45:31 2014
@@ -4755,6 +4755,10 @@ void Sema::ProcessDeclAttributeList(Scop
     return;
   }
 
+  // FIXME: We should be able to handle this in TableGen as well. It would be
+  // good to have a way to specify "these attributes must appear as a group",
+  // for these. Additionally, it would be good to have a way to specify "these
+  // attribute must never appear as a group" for attributes like cold and hot.
   if (!D->hasAttr<OpenCLKernelAttr>()) {
     // These attributes cannot be applied to a non-kernel function.
     if (Attr *A = D->getAttr<ReqdWorkGroupSizeAttr>()) {





More information about the cfe-commits mailing list