clang-apply-replacements doesn't handle windows newlines correctly

[Nikola Smiljanic]

I don't know, but I hope someone can close this once I commit the fix :)

On Thu, Dec 4, 2014 at 4:25 PM, Nico Weber <thakis at chromium.org> wrote:

> On Wed, Dec 3, 2014 at 6:43 PM, Nikola Smiljanic <popizdeh at gmail.com>
> wrote:
>
>> I think it'll only happen when you run it on Windows. Writing files in
>> text mode will translate each \n into CRLF on this silly platform :) I'm
>> honestly surprised that nobody noticed this before. I filed a bug for
>> clang-modernize for this
>> https://cpp11-migrate.atlassian.net/browse/CM-171
>>
>
> Huh, why are clang-modernize bugs in a different bug database?
>
>
>>
>> On Thu, Dec 4, 2014 at 1:29 AM, Alexander Kornienko <alexfh at google.com>
>> wrote:
>>
>>> That may be a good solution, however, could you provide a bit more
>>> details: does this problem happen when you run clang-apply-replacements on
>>> Windows or on Linux or Mac as well? It would also be nice if we could have
>>> a test for this.
>>>
>>> On Wed, Dec 3, 2014 at 4:13 AM, Nikola Smiljanic <popizdeh at gmail.com>
>>> wrote:
>>>
>>>> I'm not entirely sure this is the right way to fix the issue, but since
>>>> SourceManager reads \r \n we should probably write them without newline
>>>> translation. What happens now is, newline is read as \r \n and when it's
>>>> written out the \n is translated so we end up with duplicated \r.
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>>
>>>>
>>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141204/8a1f062c/attachment.html>