r223102 - Rely on fewer features of the 'env' command. Darwin only supports '-i'.

Hal Finkel hfinkel at anl.gov
Tue Dec 2 17:06:10 PST 2014


----- Original Message -----
> From: "Chandler Carruth" <chandlerc at gmail.com>
> To: cfe-commits at cs.uiuc.edu
> Sent: Monday, December 1, 2014 7:24:52 PM
> Subject: r223102 - Rely on fewer features of the 'env' command. Darwin only	supports '-i'.
> 
> Author: chandlerc
> Date: Mon Dec  1 19:24:52 2014
> New Revision: 223102
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=223102&view=rev
> Log:
> Rely on fewer features of the 'env' command. Darwin only supports
> '-i'.
> I'm explicitly setting LC_ALL=C somewhat for documentation, but
> hopefully this also removes some host variation from the test
> results.

FWIW, this test is failing on my system because the env command is removing the LD_LIBRARY_PATH value necessary for the just-built Clang to correctly function. Any ideas?

 -Hal

> 
> Modified:
>     cfe/trunk/test/Driver/env.c
> 
> Modified: cfe/trunk/test/Driver/env.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/env.c?rev=223102&r1=223101&r2=223102&view=diff
> ==============================================================================
> --- cfe/trunk/test/Driver/env.c (original)
> +++ cfe/trunk/test/Driver/env.c Mon Dec  1 19:24:52 2014
> @@ -5,12 +5,12 @@
>  // REQUIRES: shell
>  //
>  // The PATH variable is heavily used when trying to find a linker.
> -// RUN: env -u PATH -- %clang -no-canonical-prefixes %s -### -o %t.o
> 2>&1 \
> +// RUN: env -i LC_ALL=C %clang -no-canonical-prefixes %s -### -o
> %t.o 2>&1 \
>  // RUN:     --target=i386-unknown-linux \
>  // RUN:     --sysroot=%S/Inputs/basic_linux_tree \
>  // RUN:   | FileCheck --check-prefix=CHECK-LD-32 %s
>  //
> -// RUN: env PATH="" %clang -no-canonical-prefixes %s -### -o %t.o
> 2>&1 \
> +// RUN: env -i LC_ALL=C PATH="" %clang -no-canonical-prefixes %s
> -### -o %t.o 2>&1 \
>  // RUN:     --target=i386-unknown-linux \
>  // RUN:     --sysroot=%S/Inputs/basic_linux_tree \
>  // RUN:   | FileCheck --check-prefix=CHECK-LD-32 %s
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the cfe-commits mailing list