[PATCH] [OpenCL] fix the various -cl-* flags to relax FP arith
hfinkel at anl.gov
Mon Dec 1 13:33:55 PST 2014
----- Original Message -----
> From: "Pekka Jääskeläinen" <pekka.jaaskelainen at tut.fi>
> To: "Matt Arsenault" <Matthew.Arsenault at amd.com>, cfe-commits at cs.uiuc.edu
> Sent: Monday, December 1, 2014 3:19:40 PM
> Subject: Re: [PATCH] [OpenCL] fix the various -cl-* flags to relax FP arith
> On 12/01/2014 06:13 PM, Matt Arsenault wrote:
> > I think the test should also check for the function target
> > attribute.
> Not sure of this as Hal said that those are being phased out.
> I added a test for the attributes that were there already anyways,
> but didn't add a new attribute for the no-signed-zeros.
Sounds reasonable to me.
> > What about the other flags? I think this patch should handle (maybe
> > just
> > test?) all of the CL fast math flags instead of just this one (
> > -cl-no-signed-zeros, -cl-unsafe-math-optimizations,
> > -cl-finite-math-only, and -cl-fast-relaxed-math)
> Done. The OpenCL flags seem to be supersets of the
> flags of LLVM, so there might be more optimization
> opportunities to extract from those than these flags
> For example:
> "Allow optimizations for floating-point arithmetic that (a) assume
> arguments and results are valid, (b) may violate IEEE 754 standard
> (c) may violate the OpenCL numerical compliance requirements as
> in section 7.4 for single-precision floating-point, section 9.3.9 for
> double-precision floating-point, and edge case behavior in section
> This option includes the -cl-no-signed-zeros and -cl-mad-enable
> Now it just sets the nnans flag even though (b) and (c) allow
> pretty much anything (if read with "lawyer's eyes").
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory
More information about the cfe-commits