[PATCH] Flag Enumerator Attribute

Aaron Ballman aaron.ballman at gmail.com
Thu Nov 20 07:53:59 PST 2014


Sean and I spoke on IRC about this review, and the items we came up with were:

* Move the FlagBits value off EnumDecl and into the FlagEnumAttr itself
* Rangeify a for loop
* Remove another spurious call to getName()

~Aaron

On Wed, Nov 19, 2014 at 10:49 PM, Sean Hunt <scshunt at csclub.uwaterloo.ca> wrote:
> This fixes most of the comments from Aaron Ballman.
>
> I've left the C++ attribute syntax off, as I haven't yet considered the semantics in C++ carefully.
>
> http://reviews.llvm.org/D5853
>
> Files:
>   include/clang/AST/Decl.h
>   include/clang/Basic/Attr.td
>   include/clang/Basic/AttrDocs.td
>   include/clang/Basic/DiagnosticGroups.td
>   include/clang/Basic/DiagnosticSemaKinds.td
>   include/clang/Sema/AttributeList.h
>   include/clang/Sema/Sema.h
>   lib/Sema/SemaDecl.cpp
>   lib/Sema/SemaDeclAttr.cpp
>   lib/Sema/SemaStmt.cpp
>   test/Sema/attr-flag-enum.c
>   utils/TableGen/ClangAttrEmitter.cpp



More information about the cfe-commits mailing list