[PATCH] [libcxx] Cleanup and fix is_destructible and tests in C++03.

Eric Fiselier eric at efcs.ca
Wed Nov 19 10:00:22 PST 2014

>>! In D6316#4, @mclow.lists wrote:
> I'm unsure why we're testing for `__has_feature(cxx_noexcept)` in is_nothrow_destructible.pass.cpp

The toggle between the C++11 and C++03 implementation of  `is_nothrow_destructible` is `__has_feature(cxx_noexcept)`.  I think it is silly, but that is the way it currently works.

Comment at: test/utilities/meta/meta.unary/meta.unary.prop/is_nothrow_destructible.pass.cpp:72
@@ -70,2 +71,3 @@
+    test_is_not_nothrow_destructible<char[][3]>();
mclow.lists wrote:
> I like the idea of adding a test for an array of known bound, but did you mean `[3]` or `[][3]` ??
There is a test for an array of a known bound below. I just wanted to make sure a multi-dimensional array with an unknown bound was handled as I expected.

Comment at: test/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp:40
@@ -39,2 +39,3 @@
     virtual ~NotEmpty();
I think this change sneaked in. Is this dtor meant to be private?


More information about the cfe-commits mailing list