[PATCH] [Tooling] Restore current directory after processing each file.

Manuel Klimek klimek at google.com
Mon Nov 10 05:43:56 PST 2014


lg

================
Comment at: lib/Tooling/Tooling.cpp:312-315
@@ -307,2 +311,6 @@
 
+    // FIXME: getCompileCommands can change the state of the file system (e.g.
+    // prepare generated headers), so it needs to run right before we invoke the
+    // tool, as the next file may require a different (incompatible) state of
+    // the file system.
     std::vector<CompileCommand> CompileCommandsForFile =
----------------
I'd rephrase this to say what state we want to be in rather than what the current state is.

http://reviews.llvm.org/D6162






More information about the cfe-commits mailing list