[PATCH] Fix clash of gcc toolchains in hexagon driver regression tests
rafael.espindola at gmail.com
Fri Nov 7 09:25:36 PST 2014
+ std::string gcc_toolchain = getGCCToolchainDir(Args);
There is talk of using this style of variable names, but for now we
are still with CamelCase for variables.
LGTM with the variable name changed.
On 6 November 2014 18:37, Samuel F Antao <sfantao at us.ibm.com> wrote:
> Hi Rafael,
> Sorry about that. Not sure what I did wrong... Find attached the new patch.
> I doubled-checked this time.
> (See attached file: clang_hexagon_fix.patch)
> Rafael Espíndola <rafael.espindola at gmail.com> wrote on 11/05/2014 05:40:07
>> From: Rafael Espíndola <rafael.espindola at gmail.com>
>> To: Samuel F Antao/Watson/IBM at IBMUS
>> Cc: llvm cfe <cfe-commits at cs.uiuc.edu>
>> Date: 11/05/2014 05:40 PM
>> Subject: Re: [PATCH] Fix clash of gcc toolchains in hexagon driver
>> regression tests
>> On 5 November 2014 16:29, Samuel F Antao <sfantao at us.ibm.com> wrote:
>> > Hi Rafael,
>> > Thanks for the review. I followed your suggestion and used
>> > getGCCToolchainDir instead. git-clang-format seems not to complainabout
>> > any
>> > issues now.
>> That is odd. Running "git-clang-format master" after applying your
>> patch to a branch produces the attached patch.
>> [attachment "t.patch" deleted by Samuel F Antao/Watson/IBM]
More information about the cfe-commits