r202237 - [CMake] Apply DEPENDS intrinsics_gen in clangCodeGen.

NAKAMURA Takumi geek4civic at gmail.com
Wed Nov 5 15:04:47 PST 2014


I haven't hit this issue.
http://bb.pgr.jp/builders/msbuild-llvmclang-x64-msc17-DA/builds/1199/steps/CMake_2/logs/stdio
I guess cmake-3 would complain.

Conditionalizing is one of practical fixes, I think.
I'll plan to export Intrinsics_gen, if possible.

Thanks for the report.

2014-11-06 2:49 GMT+09:00 Reid Kleckner <rnk at google.com>:
> Hi, I can't configure a standalone Visual Studio project with this change
> because intrinsics_gen isn't exported from LLVM. What do you think the right
> fix is? Just conditionalize it on CLANG_BUILT_STANDALONE?
>
> On Tue, Feb 25, 2014 at 10:33 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
>>
>> Author: chapuni
>> Date: Wed Feb 26 00:33:27 2014
>> New Revision: 202237
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=202237&view=rev
>> Log:
>> [CMake] Apply DEPENDS intrinsics_gen in clangCodeGen.
>>
>> Modified:
>>     cfe/trunk/lib/CodeGen/CMakeLists.txt
>>
>> Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CMakeLists.txt?rev=202237&r1=202236&r2=202237&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CMakeLists.txt (original)
>> +++ cfe/trunk/lib/CodeGen/CMakeLists.txt Wed Feb 26 00:33:27 2014
>> @@ -58,6 +58,9 @@ add_clang_library(clangCodeGen
>>    MicrosoftCXXABI.cpp
>>    ModuleBuilder.cpp
>>    TargetInfo.cpp
>> +
>> +  DEPENDS
>> +  intrinsics_gen
>>    )
>>
>>  target_link_libraries(clangCodeGen
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>



More information about the cfe-commits mailing list