[clang-tools-extra] r221272 - [clang-tidy] Don't print a message if there's no error.
dblaikie at gmail.com
Tue Nov 4 10:25:12 PST 2014
On Tue, Nov 4, 2014 at 10:18 AM, Alexander Kornienko <alexfh at google.com>
> On Tue, Nov 4, 2014 at 5:32 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> On Tue, Nov 4, 2014 at 7:25 AM, Alexander Kornienko <alexfh at google.com>
>>> Author: alexfh
>>> Date: Tue Nov 4 09:25:22 2014
>>> New Revision: 221272
>>> URL: http://llvm.org/viewvc/llvm-project?rev=221272&view=rev
>>> [clang-tidy] Don't print a message if there's no error.
>> Test coverage?
> It's a trivial change, and it needs a custom configuration format handler
> to be tested which makes it relatively expensive to test it here.
Sometimes this is an indication of a chunk of functionality that isn't
tested. Is there much other coverage missing in-tree for testing custom
configuration format handlers? Perhaps all together it'd be worth adding a
custom configuration format handler, even if this one case doesn't look
Just a thought
> But rest assured that the change is going to be tested on every invocation
> of our internal build ;)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits