r221174 - Require asserts to unbreak the buildbots.

Hal Finkel hfinkel at anl.gov
Mon Nov 3 12:30:15 PST 2014


----- Original Message -----
> From: "Roman Divacky" <rdivacky at freebsd.org>
> To: cfe-commits at cs.uiuc.edu
> Sent: Monday, November 3, 2014 1:50:49 PM
> Subject: r221174 - Require asserts to unbreak the buildbots.
> 
> Author: rdivacky
> Date: Mon Nov  3 13:50:48 2014
> New Revision: 221174
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=221174&view=rev
> Log:
> Require asserts to unbreak the buildbots.
> 
> Modified:
>     cfe/trunk/test/CodeGen/ppc64-varargs-struct.c
> 
> Modified: cfe/trunk/test/CodeGen/ppc64-varargs-struct.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/ppc64-varargs-struct.c?rev=221174&r1=221173&r2=221174&view=diff
> ==============================================================================
> --- cfe/trunk/test/CodeGen/ppc64-varargs-struct.c (original)
> +++ cfe/trunk/test/CodeGen/ppc64-varargs-struct.c Mon Nov  3 13:50:48
> 2014
> @@ -1,4 +1,5 @@
>  // REQUIRES: powerpc-registered-target
> +// REQUIRES: asserts

This is fine as a temporary work-around, but the real solution (just in case this is otherwise unclear), is to loosen the regexes matching the variable names. You'll notice the existing checks in the file match arbitrary names, as in:

 // CHECK: bitcast %struct.x* %t to i8*
 // CHECK: bitcast %struct.x* %{{[0-9]+}} to i8*
 // CHECK: call void @llvm.memcpy

(of course, you can also used named regexes to be even more specific)

Also, if we're using the same test for both ppc64 and ppc, renaming it to ppc-varargs-struct.c likely makes sense.

Thanks again,
Hal

>  // RUN: %clang_cc1 -triple powerpc64-unknown-linux-gnu -emit-llvm -o
>  - %s | FileCheck %s
>  // RUN: %clang_cc1 -triple powerpc-unknown-linux-gnu -emit-llvm -o -
>  %s | FileCheck %s --check-prefix=CHECK-PPC
>  
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the cfe-commits mailing list