[PATCH] [static analyzer] Emit buffer overflow warning in strcpy fucntion when uninitialized source array of known length(> dest length) is used

Arthur O'Dwyer arthur.j.odwyer at gmail.com
Mon Nov 3 11:08:19 PST 2014


Mayur, you wrote:
> The testcase that would appropriately test the patch would be ...

but you didn't actually revise your patch.
Now, I'm pretty sure that this patch is just entirely wrong (e.g. you wrote it without being aware that `char a[3]="xyz"` is not a null-terminated string), but certainly it's bad form to "ping" before you've addressed the previous round's comments.

http://reviews.llvm.org/D6012






More information about the cfe-commits mailing list