[PATCH] MS ABI: Properly call global delete when invoking virtual destructors

Reid Kleckner rnk at google.com
Fri Oct 31 12:10:44 PDT 2014


lgtm

================
Comment at: lib/CodeGen/CGCXXABI.h:94-96
@@ -93,3 +93,5 @@
   /// when called virtually, and code generation does not support the case.
   virtual bool HasThisReturn(GlobalDecl GD) const { return false; }
 
+  virtual bool hasMostDerivedReturn(GlobalDecl GD) const { return false; }
+
----------------
rnk wrote:
> Can we write a wrapper for these that takes the this type and returns the return type of void, void*, or decltype(this)?
We discussed this in person, and it doesn't seem worth it.

http://reviews.llvm.org/D5996






More information about the cfe-commits mailing list