[PATCH] [PowerPC] Initial VSX intrinsic support, with min/max for vector double

hfinkel at anl.gov hfinkel at anl.gov
Thu Oct 30 13:55:51 PDT 2014


LGTM, thanks!

================
Comment at: include/clang/Basic/DiagnosticParseKinds.td:345
@@ +344,3 @@
+def err_invalid_vector_double_decl_spec : Error <
+  "use of 'double' with '__vector' requires target CPU of power7 or later">;
+def err_invalid_vector_long_double_decl_spec : Error<
----------------
We're using the capitalization convention, right?

  requires a target CPU of POWER7 or later

(might as well not skimp on the articles)

On the other hand, this could get a little misleading if compiling with -mcpu=power7 -mno-vsx, so maybe we should say:

  requires VSX support to be enabled (available on the POWER7 or later)

http://reviews.llvm.org/D5949






More information about the cfe-commits mailing list