[PATCH] unique_ptrify ownership of ModuleFiles in the ModuleManager

David Blaikie dblaikie at gmail.com
Fri Oct 24 10:31:00 PDT 2014

Hi rsmith,

We could maintain ownership in 'Chain' rather than 'Modules', though that'll
require a little more reordering in removeModules (if it's OK to just move the
Chain loop/remove_if to after the victim loop, then that's easy)

The main uncertainty I have about this change is whether it's safe to move the
Modules.erase from the start of the victim loop (in removeModules) to the end.
Is that OK? Or do some of the operations in the mody of that loop rely on the
entry to have already been removed from 'Modules'?)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5980.15420.patch
Type: text/x-patch
Size: 3389 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141024/e8a3dbcf/attachment.bin>

More information about the cfe-commits mailing list