[libcxx] r220512 - [libcxx] XFAIL all currently failing libc++ tests for linux.

Eric Fiselier eric at efcs.ca
Thu Oct 23 14:17:36 PDT 2014


Author: ericwf
Date: Thu Oct 23 16:17:36 2014
New Revision: 220512

URL: http://llvm.org/viewvc/llvm-project?rev=220512&view=rev
Log:
[libcxx] XFAIL all currently failing libc++ tests for linux.

Summary:
Pretty please? We now have a significant number of builders that test libc++. I really want those builders to be green.
Most of these failures are due to differences in locale data, including those in regex. I will continue working on fixing the locale and regex tests but there is no consensus on what the correct direction to go. 

Since the builders display a list of XFAIL tests they are by no means hidden. It just means they are expected failures. Now unexpected failures won't get mixed in with well known and expected failures.

Reviewers: mclow.lists, jroelofs, danalbert

Reviewed By: danalbert

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D5941

Modified:
    libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp
    libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp
    libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp
    libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp
    libcxx/trunk/test/re/re.alg/re.alg.match/basic.pass.cpp
    libcxx/trunk/test/re/re.alg/re.alg.match/ecma.pass.cpp
    libcxx/trunk/test/re/re.alg/re.alg.match/extended.pass.cpp
    libcxx/trunk/test/re/re.alg/re.alg.search/awk.pass.cpp
    libcxx/trunk/test/re/re.alg/re.alg.search/basic.pass.cpp
    libcxx/trunk/test/re/re.alg/re.alg.search/ecma.pass.cpp
    libcxx/trunk/test/re/re.alg/re.alg.search/extended.pass.cpp
    libcxx/trunk/test/re/re.traits/lookup_collatename.pass.cpp
    libcxx/trunk/test/re/re.traits/translate_nocase.pass.cpp

Modified: libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,11 @@
 //     has any difference from "C" collation.  But I do believe I'm picking
 //     up the OS's collation files.
 
+// TODO investigation needed.
+// Glibc seems to collate files differently from the way Apple's C library does
+// it.
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <string>
 #include <cassert>

Modified: libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp Thu Oct 23 16:17:36 2014
@@ -16,6 +16,9 @@
 // iter_type get(iter_type b, iter_type e, bool intl, ios_base& iob,
 //               ios_base::iostate& err, long double& v) const;
 
+// TODO For zh_CN GLIBC puts the negative sign after the currency symbol.
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <ios>
 #include <streambuf>

Modified: libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp Thu Oct 23 16:17:36 2014
@@ -16,6 +16,9 @@
 // iter_type put(iter_type s, bool intl, ios_base& f, char_type fill,
 //               long double units) const;
 
+// TODO For zh_CN GLIBC puts the negative sign after the currency symbol.
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <ios>
 #include <streambuf>

Modified: libcxx/trunk/test/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,12 @@
 
 // charT thousands_sep() const;
 
+// Failure related to GLIBC's use of U00A0 as mon_thousands_sep
+// and U002E as mon_decimal_point.
+// TODO: U00A0 should be investigated.
+// Possibly related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16006
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <limits>
 #include <cassert>

Modified: libcxx/trunk/test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp Thu Oct 23 16:17:36 2014
@@ -13,6 +13,9 @@
 
 // iter_type put(iter_type s, ios_base& iob, char_type fill, long double v) const;
 
+// TODO GLIBC uses a different string for positive and negative NAN numbers.
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <ios>
 #include <cassert>

Modified: libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp Thu Oct 23 16:17:36 2014
@@ -19,6 +19,9 @@
 // iter_type get(iter_type s, iter_type end, ios_base& f,
 //               ios_base::iostate& err, tm *t, char format, char modifier = 0) const;
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <cassert>
 #include "test_iterators.h"

Modified: libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp Thu Oct 23 16:17:36 2014
@@ -19,6 +19,9 @@
 // iter_type get(iter_type s, iter_type end, ios_base& f,
 //               ios_base::iostate& err, tm *t, char format, char modifier = 0) const;
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <cassert>
 #include "test_iterators.h"

Modified: libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp Thu Oct 23 16:17:36 2014
@@ -20,6 +20,9 @@
 // get_weekday(iter_type s, iter_type end, ios_base& str,
 //             ios_base::iostate& err, tm* t) const;
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <cassert>
 #include "test_iterators.h"

Modified: libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp Thu Oct 23 16:17:36 2014
@@ -20,6 +20,9 @@
 // get_weekday(iter_type s, iter_type end, ios_base& str,
 //             ios_base::iostate& err, tm* t) const;
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <cassert>
 #include "test_iterators.h"

Modified: libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp Thu Oct 23 16:17:36 2014
@@ -24,6 +24,9 @@
 //     ~time_put_byname();
 // };
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <cassert>
 #include "test_iterators.h"

Modified: libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp Thu Oct 23 16:17:36 2014
@@ -14,6 +14,9 @@
 // iter_type put(iter_type s, ios_base& str, char_type fill, const tm* t,
 //               char format, char modifier = 0) const;
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <cassert>
 #include "test_iterators.h"

Modified: libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp Thu Oct 23 16:17:36 2014
@@ -16,6 +16,9 @@
 
 // string grouping() const;
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <cassert>
 

Modified: libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp (original)
+++ libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp Thu Oct 23 16:17:36 2014
@@ -16,6 +16,9 @@
 
 // char_type thousands_sep() const;
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <locale>
 #include <cassert>
 

Modified: libcxx/trunk/test/re/re.alg/re.alg.match/basic.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.alg/re.alg.match/basic.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.alg/re.alg.match/basic.pass.cpp (original)
+++ libcxx/trunk/test/re/re.alg/re.alg.match/basic.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,9 @@
 //                  const basic_regex<charT, traits>& e,
 //                  regex_constants::match_flag_type flags = regex_constants::match_default);
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <cassert>
 

Modified: libcxx/trunk/test/re/re.alg/re.alg.match/ecma.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.alg/re.alg.match/ecma.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.alg/re.alg.match/ecma.pass.cpp (original)
+++ libcxx/trunk/test/re/re.alg/re.alg.match/ecma.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,9 @@
 //                  const basic_regex<charT, traits>& e,
 //                  regex_constants::match_flag_type flags = regex_constants::match_default);
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <cassert>
 

Modified: libcxx/trunk/test/re/re.alg/re.alg.match/extended.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.alg/re.alg.match/extended.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.alg/re.alg.match/extended.pass.cpp (original)
+++ libcxx/trunk/test/re/re.alg/re.alg.match/extended.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,9 @@
 //                  const basic_regex<charT, traits>& e,
 //                  regex_constants::match_flag_type flags = regex_constants::match_default);
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <cassert>
 

Modified: libcxx/trunk/test/re/re.alg/re.alg.search/awk.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.alg/re.alg.search/awk.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.alg/re.alg.search/awk.pass.cpp (original)
+++ libcxx/trunk/test/re/re.alg/re.alg.search/awk.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,9 @@
 //                  const basic_regex<charT, traits>& e,
 //                  regex_constants::match_flag_type flags = regex_constants::match_default);
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <cassert>
 

Modified: libcxx/trunk/test/re/re.alg/re.alg.search/basic.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.alg/re.alg.search/basic.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.alg/re.alg.search/basic.pass.cpp (original)
+++ libcxx/trunk/test/re/re.alg/re.alg.search/basic.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,9 @@
 //                  const basic_regex<charT, traits>& e,
 //                  regex_constants::match_flag_type flags = regex_constants::match_default);
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <cassert>
 

Modified: libcxx/trunk/test/re/re.alg/re.alg.search/ecma.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.alg/re.alg.search/ecma.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.alg/re.alg.search/ecma.pass.cpp (original)
+++ libcxx/trunk/test/re/re.alg/re.alg.search/ecma.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,9 @@
 //                  const basic_regex<charT, traits>& e,
 //                  regex_constants::match_flag_type flags = regex_constants::match_default);
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <cassert>
 

Modified: libcxx/trunk/test/re/re.alg/re.alg.search/extended.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.alg/re.alg.search/extended.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.alg/re.alg.search/extended.pass.cpp (original)
+++ libcxx/trunk/test/re/re.alg/re.alg.search/extended.pass.cpp Thu Oct 23 16:17:36 2014
@@ -18,6 +18,9 @@
 //                  const basic_regex<charT, traits>& e,
 //                  regex_constants::match_flag_type flags = regex_constants::match_default);
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <cassert>
 

Modified: libcxx/trunk/test/re/re.traits/lookup_collatename.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.traits/lookup_collatename.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.traits/lookup_collatename.pass.cpp (original)
+++ libcxx/trunk/test/re/re.traits/lookup_collatename.pass.cpp Thu Oct 23 16:17:36 2014
@@ -17,6 +17,9 @@
 //   string_type
 //   lookup_collatename(ForwardIterator first, ForwardIterator last) const;
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <iterator>
 #include <cassert>

Modified: libcxx/trunk/test/re/re.traits/translate_nocase.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.traits/translate_nocase.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
==============================================================================
--- libcxx/trunk/test/re/re.traits/translate_nocase.pass.cpp (original)
+++ libcxx/trunk/test/re/re.traits/translate_nocase.pass.cpp Thu Oct 23 16:17:36 2014
@@ -17,6 +17,9 @@
 // XFAIL: with_system_lib=x86_64-apple-darwin11
 // XFAIL: with_system_lib=x86_64-apple-darwin12
 
+// TODO: investigation needed
+// XFAIL: linux-gnu
+
 #include <regex>
 #include <cassert>
 





More information about the cfe-commits mailing list