[PATCH] Resubmit "Improve Windows toolchain support for non-standard environments."

Hans Wennborg hans at chromium.org
Tue Oct 21 13:33:03 PDT 2014

Comment at: lib/Driver/WindowsToolChain.cpp:218
@@ +217,3 @@
+// Get the location to use for Visual Studio binaries.  The location priority
+// is: %VCINSTALLDIR% > %PATH% > newest copy of Visual Studio installed on
+// system (as reported by the registry).
I wonder if we should check PATH first.

If the user runs "cl.exe", she expects the one on PATH to be run. If she uses clang-cl.exe instead, and we fall back, that's the cl.exe we should use.


More information about the cfe-commits mailing list