[PATCH] [libcxxabi] Document the standalone build's requirements on llvm-config and llvm sources.

Jonathan Roelofs jonathan at codesourcery.com
Thu Oct 16 19:53:58 PDT 2014


================
Comment at: www/index.html:100
@@ +99,3 @@
+  <p> By default CMake uses <code>llvm-config</code> to locate the required
+      LLVM sources. If CMake cannot find <code>llvm-config</code> then you must
+      configure CMake using either of the following options.
----------------
perhaps you can also coerce cmake into barfing in such a way as to display this message when the appropriate circumstance comes up?

================
Comment at: www/index.html:104
@@ +103,3 @@
+  <ul>
+  <li><code>-DLLVM_CONFIG=path/to/llvm-config</code></li>
+  <li><code>-DLLVM_PATH=path/to/llvm/sources</code></li>
----------------
this one looks ok

================
Comment at: www/index.html:105
@@ +104,3 @@
+  <li><code>-DLLVM_CONFIG=path/to/llvm-config</code></li>
+  <li><code>-DLLVM_PATH=path/to/llvm/sources</code></li>
+  </ul>
----------------
but ones like this tend to confuse me when I see them because I'm never quite sure which folder it's asking me to point it at.

Some alternative bikeshed colors (none of which I particularly like):
<li><code>-DLLVM_PATH=path/to/llvm/</code></li>
<li><code>-DLLVM_PATH=path/to/llvm/lib/../</code></li>
<li><code>-DLLVM_PATH=path/to/llvm-source-root/</li>

http://reviews.llvm.org/D5836






More information about the cfe-commits mailing list