r219679 - [SystemZ] Add test case to verify default use of integrated assembler

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Tue Oct 14 09:49:39 PDT 2014


David Blaikie <dblaikie at gmail.com> wrote on 14.10.2014 17:41:35:

> Out of curiosity - were there tests for the default assembler on
> other achitectures? (if you change the default so that no
> architecture uses the integrated assembler by default, do other
> tests fail? Maybe you can find existing tests of this functionality
> for other achitectures so you can put this test beside/in/with those
> existing tests)

Well, I looked and didn't find any such tests on other architectures,
which is why I initially didn't have one for SystemZ either ... but then
Eric requested that I should add one, so I did :-)

> +// RUN: %clang -target s390x-ibm-linux -integrated-as -### -c %s 2>&1 \
> +// RUN: | FileCheck -check-prefix=IAS %s
> +// IAS: "-cc1as"{{.*}} "-target-cpu" "z10"
>
> If you like, you could do these first two with the same CHECK line
> (I'd probably just use the default CHECK suffix)
>
> +
> +// RUN: %clang -target s390x-ibm-linux -no-integrated-as -### -c %s 2>&1
\
> +// RUN: | FileCheck -check-prefix=NO-IAS %s
> +// NO-IAS: "-march=z10"
>
> & maybe test this with CHECK-NOT: "-cc1as" might be more direct/
> obvious what it's testing?

OK, good points.  I'll make those changes.

Thanks,
Ulrich





More information about the cfe-commits mailing list