r219472 - XFAIL coverage -no-integrated-as tests for msvc.

Aaron Ballman aaron at aaronballman.com
Fri Oct 10 06:03:33 PDT 2014


On Fri, Oct 10, 2014 at 12:28 AM, Dan Albert <danalbert at google.com> wrote:
> Author: danalbert
> Date: Thu Oct  9 23:28:04 2014
> New Revision: 219472
>
> URL: http://llvm.org/viewvc/llvm-project?rev=219472&view=rev
> Log:
> XFAIL coverage -no-integrated-as tests for msvc.
>
> Windows can't use -no-integrated-as, so split these tests out into a
> separate file and XFAIL them for win32,win64.
>
> Added:
>     cfe/trunk/test/Driver/coverage_no_integrated_as.c
> Modified:
>     cfe/trunk/test/Driver/clang_f_opts.c
>
> Modified: cfe/trunk/test/Driver/clang_f_opts.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/clang_f_opts.c?rev=219472&r1=219471&r2=219472&view=diff
> ==============================================================================
> --- cfe/trunk/test/Driver/clang_f_opts.c (original)
> +++ cfe/trunk/test/Driver/clang_f_opts.c Thu Oct  9 23:28:04 2014
> @@ -67,17 +67,11 @@
>  // CHECK-NO-PROFILE-ARCS-NOT: "-femit-coverage-data"
>
>  // RUN: %clang -### -S -fprofile-arcs %s 2>&1 | FileCheck -check-prefix=CHECK-GCNO-DEFAULT-LOCATION %s
> -// RUN: %clang -### -S -fprofile-arcs -no-integrated-as %s 2>&1 | FileCheck -check-prefix=CHECK-GCNO-DEFAULT-LOCATION %s
>  // RUN: %clang -### -c -fprofile-arcs %s 2>&1 | FileCheck -check-prefix=CHECK-GCNO-DEFAULT-LOCATION %s
> -// RUN: %clang -### -c -fprofile-arcs -no-integrated-as %s 2>&1 | FileCheck -check-prefix=CHECK-GCNO-DEFAULT-LOCATION %s
>  // RUN: %clang -### -S -fprofile-arcs %s -o /foo/bar.o 2>&1 | FileCheck -check-prefix=CHECK-GCNO-LOCATION %s
> -// RUN: %clang -### -S -fprofile-arcs -no-integrated-as %s -o /foo/bar.o 2>&1 | FileCheck -check-prefix=CHECK-GCNO-LOCATION %s
>  // RUN: %clang -### -c -fprofile-arcs %s -o /foo/bar.o 2>&1 | FileCheck -check-prefix=CHECK-GCNO-LOCATION %s
> -// RUN: %clang -### -c -fprofile-arcs -no-integrated-as %s -o /foo/bar.o 2>&1 | FileCheck -check-prefix=CHECK-GCNO-LOCATION %s
>  // RUN: %clang -### -S -fprofile-arcs %s -o foo/bar.o 2>&1 | FileCheck -check-prefix=CHECK-GCNO-LOCATION-REL-PATH %s
> -// RUN: %clang -### -S -fprofile-arcs -no-integrated-as %s -o foo/bar.o 2>&1 | FileCheck -check-prefix=CHECK-GCNO-LOCATION-REL-PATH %s
>  // RUN: %clang -### -c -fprofile-arcs %s -o foo/bar.o 2>&1 | FileCheck -check-prefix=CHECK-GCNO-LOCATION-REL-PATH %s
> -// RUN: %clang -### -c -fprofile-arcs -no-integrated-as %s -o foo/bar.o 2>&1 | FileCheck -check-prefix=CHECK-GCNO-LOCATION-REL-PATH %s
>  // CHECK-GCNO-DEFAULT-LOCATION: "-coverage-file" "{{.*}}{{[/\]}}clang_f_opts.c"
>  // CHECK-GCNO-DEFAULT-LOCATION-NOT: "-coverage-file" "{{[/\]}}tmp{{[/\]}}{{.*}}{{[/\]}}clang_f_opts.c"
>  // CHECK-GCNO-LOCATION: "-coverage-file" "{{[/\]}}foo{{[/\]}}bar.o"

This test is still failing for me on Windows, because of the preceding
check. That's not a valid absolute path on Windows. For comparison,
this is what is generated for me:

"-coverage-file" "E:\\llvm\\2013\\tools\\clang\\test\\Driver/foo/bar.o"

I don't believe this RUN line is valid in Windows environments:

// RUN: %clang -### -c -fprofile-arcs %s -o /foo/bar.o 2>&1 |
FileCheck -check-prefix=CHECK-GCNO-LOCATION %s

~Aaron



More information about the cfe-commits mailing list