[PATCH] [OPENMP] Codegen for 'private' clause in 'parallel' directive

hfinkel at anl.gov hfinkel at anl.gov
Tue Oct 7 06:08:30 PDT 2014


================
Comment at: lib/Sema/SemaOpenMP.cpp:3139
@@ +3138,3 @@
+    // IdResolver, so the code in the OpenMP region uses original variable for
+    // proper diagnostics and variable capturing.
+    auto VDPrivate =
----------------
Also, "proper diagnostics" I understand (we don't want diagnostic messages saying that variables are declared inside of OpenMP clauses -- that would get confusing). I don't understand what you mean here by "variable capturing", but I also thing the point is: how much do we want the presence of the OpenMP clauses to affect the AST, and regarding adding an extra layer of indirection for all variables inside the clause when -fopenmp is enabled, I think it makes sense that we don't want that.

http://reviews.llvm.org/D4752






More information about the cfe-commits mailing list