r218769 - Refactor Matcher<T> and DynTypedMatcher to reduce overhead of casts.

[Hans Wennborg]

On Wed, Oct 1, 2014 at 10:43 AM, Samuel Benzaquen <sbenza at google.com> wrote:
> On Wed, Oct 1, 2014 at 1:38 PM, Samuel Benzaquen <sbenza at google.com> wrote:
>>
>> On Wed, Oct 1, 2014 at 1:35 PM, Hans Wennborg <hans at chromium.org> wrote:
>>>
>>> On Wed, Oct 1, 2014 at 8:08 AM, Samuel Benzaquen <sbenza at google.com>
>>> wrote:
>>> > Author: sbenza
>>> > Date: Wed Oct  1 10:08:07 2014
>>> > New Revision: 218769
>>> >
>>> > URL: http://llvm.org/viewvc/llvm-project?rev=218769&view=rev
>>> > Log:
>>> > Refactor Matcher<T> and DynTypedMatcher to reduce overhead of casts.
>>>
>>> Chapuni's Win buildbots seem to be failing after this revision:
>>>
>>> http://bb.pgr.jp/builders/ninja-clang-i686-msc17-R/builds/10766/
>>
>>
>> Taking a look...
>
>
> Is the problem the delegated constructor at
> clang/ASTMatchers/ASTMatchersInternal.h:367 ?

Sounds plausible. I don't have an up-to-date VS2012 build to confirm,
but [1] suggests delegating constructors aren't supported.

 1. http://msdn.microsoft.com/en-us/library/hh567368.aspx