[PATCH] Modernize the TableGen code by using C++11 range-based for loops

Tobias Grosser tobias at grosser.es
Wed Sep 24 22:11:13 PDT 2014


On 25/09/2014 06:20, Ehsan Akhgari wrote:
> http://reviews.llvm.org/D5488

It seems you are only using plain 'auto'. This will cause unnecessary 
copies and in cases where copies are cheap (as they are pointers) this 
is not obvious from looking at the code.

This link explains the issues and the right way to use auto in range 
based loops:

http://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto

Cheers,
Tobias



More information about the cfe-commits mailing list