[PATCH] Promote NPCs used as arguments to variadic functions

David Majnemer david.majnemer at gmail.com
Wed Sep 24 14:20:00 PDT 2014


Perhaps a warning should be added so code doesn't "miscompile" when compiled with GCC?

Is there a reason to restrict this just to null pointer constants?

================
Comment at: lib/CodeGen/CGCall.cpp:2601
@@ +2600,3 @@
+                                 Expr::NPC_ValueDependentIsNotNull)) {
+    llvm::errs() << "getVarArgType, getIntPtrType\n";
+    return getContext().getIntPtrType();
----------------
This should be removed.

http://reviews.llvm.org/D5480






More information about the cfe-commits mailing list