[PATCH] Make analyzer check all argument for nonnull attribute

Daniel Fahlgren daniel at fahlgren.se
Wed Sep 24 08:46:33 PDT 2014


Hi,

This patch fixes the fixme in NonNullParamChecker about multiple
attributes. It does that by iterating over all parameters for all
nonnull-attributes the function has.

For a function with a lot of parameters and many attributes that might
seem a bit wasteful. However, that is likely not a problem on real code.
I also ran some synthetic benchmarks on a worst case scenario (25
parameters and 25 nonnull attributes) and couldn't find any noticeable
performance issue.

Any comments or feedback?

Best regards,
Daniel Fahlgren
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nonnull.patch
Type: text/x-patch
Size: 4419 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140924/36aa583f/attachment.bin>


More information about the cfe-commits mailing list