[PATCH] make analyzer track memory allocated by if_nameindex

Daniel Fahlgren daniel at fahlgren.se
Wed Sep 24 03:06:34 PDT 2014


Hi Anna,

On Mon, 2014-09-22 at 22:54 -0700, Anna Zaks wrote:
> The bodies of these functions look very similar. Please, try to factor
> out the copy and paste.
> +bool MallocChecker::isIfNameFunction(const FunctionDecl *FD,
> +bool MallocChecker::isIfFreeNameFunction(const FunctionDecl *FD,
> ASTContext &C) const {

> Otherwise, looks good to me.

Thanks for reviewing this. Attached is an updated patch where the two
functions are refactored to a single one.

Best regards,
Daniel Fahlgren
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ifnameindex.patch
Type: text/x-patch
Size: 9770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140924/2e55f05b/attachment.bin>


More information about the cfe-commits mailing list