[PATCH] [OPENMP] Codegen for 'firstprivate' clause in 'parallel' directive

[Hal Finkel]

----- Original Message -----
> From: "Alexey Bataev" <a.bataev at hotmail.com>
> To: "a bataev" <a.bataev at hotmail.com>, dgregor at apple.com, fraggamuffin at gmail.com, richard at metafoo.co.uk,
> rjmccall at gmail.com, ejstotzer at gmail.com, hfinkel at anl.gov
> Cc: cfe-commits at cs.uiuc.edu
> Sent: Monday, September 22, 2014 11:26:56 PM
> Subject: Re: [PATCH] [OPENMP] Codegen for 'firstprivate' clause in 'parallel' directive
> 
> > Please separate out the Sema changes from this patch into a
> > separate patch.
> Hal, the changes in Sema are required for codegen only. I won't be
> able to test them without codegen.
> 

Okay, obviously there are changes to the Sema tests because the messages have changed. Can you commit that change separately? If this is not reasonable/possible, please explain why.

Also, regarding the addition of the '*PrivateCopies' functions to the AST nodes, can you please explain the design? I don't understand why you seem to be duplicating some of the variables in the AST.

Thanks again,
Hal

[snip]

> 
> http://reviews.llvm.org/D5140
> 
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory