r218269 - MS ABI: Remove a FIXME that has been fixed

David Majnemer david.majnemer at gmail.com
Mon Sep 22 13:39:37 PDT 2014


Author: majnemer
Date: Mon Sep 22 15:39:37 2014
New Revision: 218269

URL: http://llvm.org/viewvc/llvm-project?rev=218269&view=rev
Log:
MS ABI: Remove a FIXME that has been fixed

We've implemented MSVC-style RTTI for quite some time.

Modified:
    cfe/trunk/lib/AST/VTableBuilder.cpp

Modified: cfe/trunk/lib/AST/VTableBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/VTableBuilder.cpp?rev=218269&r1=218268&r2=218269&view=diff
==============================================================================
--- cfe/trunk/lib/AST/VTableBuilder.cpp (original)
+++ cfe/trunk/lib/AST/VTableBuilder.cpp Mon Sep 22 15:39:37 2014
@@ -2539,8 +2539,9 @@ private:
                   BasesSetVectorTy &VisitedBases);
 
   void LayoutVFTable() {
-    // FIXME: add support for RTTI when we have proper LLVM support for symbols
-    // pointing to the middle of a section.
+    // RTTI data goes before all other entries.
+    if (HasRTTIComponent)
+      Components.push_back(VTableComponent::MakeRTTI(MostDerivedClass));
 
     BasesSetVectorTy VisitedBases;
     AddMethods(BaseSubobject(MostDerivedClass, CharUnits::Zero()), 0, nullptr,
@@ -2579,8 +2580,6 @@ public:
     // definition of the vftable.
     HasRTTIComponent = Context.getLangOpts().RTTIData &&
                        !MostDerivedClass->hasAttr<DLLImportAttr>();
-    if (HasRTTIComponent)
-      Components.push_back(VTableComponent::MakeRTTI(MostDerivedClass));
 
     LayoutVFTable();
 





More information about the cfe-commits mailing list