[patch] Delay __fastcall attribute checking utnil after merging declarations

[Reid Kleckner]

Looks good.

+      // MSVC system headers sometimes accidentally use stdcall without
+      // (void) parameters, so use a default-error warning in this case :-/

Just to be pedantic, the ImmDisableLegacyIME() is provided by the Windows
SDK, so I'd say "Windows system headers" instead of MSVC.

On Fri, Sep 19, 2014 at 3:06 PM, Nico Weber <thakis at chromium.org> wrote:

> (Sorry, forgot about this.)
>
> On Thu, Aug 21, 2014 at 11:27 AM, Reid Kleckner <rnk at google.com> wrote:
>
>> On Tue, Aug 19, 2014 at 10:40 AM, Nico Weber <thakis at chromium.org> wrote:
>>>
>>> I did give it a try, and rejecting stdcall fires on Windows SDK headers:
>>>
>>> ...win8sdk/Include/um\imm.h(432,13) :  error(clang): function with no
>>> prototype cannot use stdcall calling convention
>>> BOOL WINAPI ImmDisableLegacyIME();
>>>             ^
>>>
>>
>> Bummer. :( We could make it a default error warning, thereby suppressing
>> it in system headers, I guess.
>>
>
> That's a good idea; it seems to work in practice. Here's how it looks.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140919/5627ba9a/attachment.html>