Put more stuff in the comdat used for variables with static init

Reid Kleckner rnk at google.com
Fri Sep 19 11:32:47 PDT 2014


lgtm

On Fri, Sep 19, 2014 at 10:50 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> On 19 September 2014 12:57, Reid Kleckner <rnk at google.com> wrote:
> > I think we want this comdat grouping on mingw. Unlike C5/D5, the global
> > variable is a real symbol that is a member of the comdat group. I think
> the
> > check should still be !MachO, but the code that sets the comdat of the
> > global and the initializer function needs to be sunk into the
> > ItaniumCXXABI.cpp code.
>
> Make sense. The attached patch does all the work from
> lib/CodeGen/ItaniumCXXABI.cpp.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140919/06393d8f/attachment.html>


More information about the cfe-commits mailing list