Put more stuff in the comdat used for variables with static init

Reid Kleckner rnk at google.com
Thu Sep 18 18:52:21 PDT 2014


The global_ctors patch seems fine, but I think David approved the previous
patch prematurely.

The initializer code on Windows is already in its own comdat while the
global_ctors entry is in the comdat with the global. We should leave that
as is.

I also think you need to put the the global (the key) into a proper comdat,
and not just leave it as a linkonce_odr global.

On Thu, Sep 18, 2014 at 5:06 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> On 18 September 2014 19:35, Reid Kleckner <rnk at google.com> wrote:
> > We should also omit the third entry in @llvm.global_ctors.
>
> How about the attached patch for clang?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140918/844b06cb/attachment.html>


More information about the cfe-commits mailing list