[PATCH] [libc++] Support newlib as libc++'s C library [locale part]

Jonathan Roelofs jonathan at codesourcery.com
Thu Sep 18 07:14:54 PDT 2014


It looks like SunOS's isascii is a macro: http://docs.oracle.com/cd/E19683-01/816-0213/6m6ne383q/index.html

@joerg For the ctype<char> ones, I think that's fine, but I don't think that works for ctype<wchar_t> because classic_table has only at least 256 entries. That would get isascii out of include/__locale, and we can leave the ones in src/locale.cpp, which solves this messiness.

================
Comment at: include/locale:199
@@ +198,3 @@
+// include of <sys/cdefs.h> once https://sourceware.org/ml/newlib-cvs/2014-q3/msg00038.html
+// has had a chance to bake for a bit
+#include <support/newlib/xlocale.h>
----------------
jfb wrote:
> FWIW newlib has yearly releases around Christmas time, so "a bit" may be "quite a bit" ;-)
oh boy, yeah. I didn't know their release schedule was that infrequent :)

http://reviews.llvm.org/D5385






More information about the cfe-commits mailing list