[PATCH] [libc++] Support newlib as libc++'s C library [locale part]

Jonathan Roelofs jonathan at codesourcery.com
Wed Sep 17 11:29:45 PDT 2014


Yeah, it would be better to share the implementation of these between android and newlib. Where's the right place to put that kind of shared thing?

================
Comment at: include/support/newlib/xlocale.h:64
@@ +63,3 @@
+
+static inline int isdigit_l(char c, locale_t l) {
+   (void) l;
----------------
jfb wrote:
> mclow.lists wrote:
> > Comment lost the first time. Sigh.
> > 
> > this should be written as:
> >      `static inline int isdigit_l(char c, locale_t)`
> > 
> > You can't use the second parameter if you don't name it.
> > 
> Cleaner to just not give a name to `locale_t l` here and below instead of `(void) l;`?
Yeah.. brainfart.

http://reviews.llvm.org/D5385






More information about the cfe-commits mailing list