[PATCH] [libc++] Support newlib as libc++'s C library

JF Bastien jfb at chromium.org
Wed Sep 17 10:58:44 PDT 2014


================
Comment at: include/__locale:34
@@ -33,1 +33,3 @@
 
+// Newlib doesn't have the following C extensions for locales.
+#if defined(_NEWLIB_VERSION)
----------------
thakis wrote:
> Is it possible to add this in newlib instead?
These are extensions to C:
  http://pubs.opengroup.org/onlinepubs/9699919799/functions/isxdigit.html

I don't think they necessarily belong in newlib, but I didn't try having the conversation upstream. They were receptive to my patches (see ~December 2013), but I talked to Roland McGrath before making changes to make sure someone better versed in C libraries agreed with the changes I was proposing (and what should be fixed in newlib versus libc++).

http://reviews.llvm.org/D5383






More information about the cfe-commits mailing list