clang-format: Allow unbroken ::: in inline assembly

Eugene Toder eltoder at gmail.com
Tue Sep 16 08:41:01 PDT 2014


Thank you. Now with a test.

Eugene


On Mon, Sep 15, 2014 at 6:10 PM, Daniel Jasper <djasper at google.com> wrote:

> I think the change itself look good (although I don't use inline assembly
> much). Please add a test.
>
> On Mon, Sep 15, 2014 at 11:14 PM, Eugene Toder <eltoder at gmail.com> wrote:
>
>> Hello,
>>
>> When inline assembly has only clobber constraints it's common to write
>> all three colons without spaces, for example:
>>
>> asm volatile("nop" ::: "memory");
>>
>> Currently clang-format splits ::: into coloncolon and colon, and inserts
>> a space before the colon, which looks strange:
>>
>> asm volatile("nop" :: : "memory");
>>
>> I suggest to allow having ::: without spaces in this case. Attached is a
>> simple patch to that effect.
>>
>> Thanks,
>> Eugene
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140916/3a21414c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asm-triple-colon.patch
Type: text/x-patch
Size: 1216 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140916/3a21414c/attachment.bin>


More information about the cfe-commits mailing list