[PATCH/RFC] Fix -fdelayed-template-parsing leaks with enableIncrementalProcessing

Reid Kleckner rnk at google.com
Mon Sep 15 11:42:25 PDT 2014


lgtm

+    if(LateTemplateParserCleanup)
+      LateTemplateParserCleanup(OpaqueParser);

Should be "if (".

Thanks!

On Mon, Sep 15, 2014 at 11:25 AM, Brad King <brad.king at kitware.com> wrote:

> On 09/02/2014 05:21 PM, Reid Kleckner wrote:
> > +Ben Kramer, since he wrote r154743.
> >
> > It seems reasonable for Sema to ask Parser to clean things up at the
> > end of ActOnEndOfTranslationUnit. In this particular edge case we
> > don't have a Parser call bracketing the Sema methods, so we have
> > to resort to something more explicit.
>
> Thanks.  I've rebased on r217789 to resolve a logical conflict.
>
> -Brad
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140915/101926df/attachment.html>


More information about the cfe-commits mailing list