[PATCH] [libc++abi] Support for __cxa_bad_array_new_length

Aaron Ballman aaron at aaronballman.com
Thu Sep 11 06:39:50 PDT 2014


On Wed, Sep 10, 2014 at 11:52 AM, Dan Albert <danalbert at google.com> wrote:
> Sorry, I got used to relying on phabricator to keep track of things, and
> forgot about this one.

No worries!

> Could you split the test in to a separate file and add `// XFAIL: *` at the
> top? That way you can commit it with the guts of the patch and we don't have
> to worry about forgetting to submit the test later.
>
> Other than that, LGTM.

I've split the test out into its own file, and have attached the patch here.

Since I don't have a way to test this locally, and no other tests have
XFAIL lines, I'm not quite comfortable committing this without someone
who can run the tests confirming that it runs cleanly.

Thanks!

~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: __cxa_bad_array_new_length_v4.patch
Type: application/octet-stream
Size: 2785 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140911/6867b05d/attachment.obj>


More information about the cfe-commits mailing list