[PATCH] Fix clash of gcc toolchains in driver regression tests

Samuel F Antao sfantao at us.ibm.com
Wed Sep 10 16:02:10 PDT 2014


Hi all,

Some regression tests for the driver rely on the minimal/dummy system root
that comes in the Inputs folder included in the clang driver tests’s
folder. The path to the right toolchain is specified using the —sysroot
switch. However, if clang was configured with a custom gcc toolchain
(either by using GCC_INSTALL_PREFIX in cmake or the equivalent configure
command), the path to the custom gcc toolchain path takes precedence to the
one specified by sysroot. This causes several regression tests to fail as
they will be using an unexpected path.

This patch fixes this issue by adding --gcc-toolchain=“” to all tests that
rely on that. The empty string causes the driver to pick the path from
sysroot instead. There aren’t any changes in the driver’s code, only the
tests are modified. The driver's regression tests for hexagon also have
similar issues but these require modifications in the driver’s code. I’ll
send these fixes in a separate patch.

The modified files are the following:
test/Driver/constructors.c

test/Driver/gcc-version-debug.c

test/Driver/linux-header-search.cpp

test/Driver/linux-ld.c

test/Driver/mips-reduced-toolchain.cpp



Thanks,

Sam

(See attached file: clang_gcc_toolchain_gen_and_mips_fix.patch)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140910/5b949cc5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang_gcc_toolchain_gen_and_mips_fix.patch
Type: application/octet-stream
Size: 52234 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140910/5b949cc5/attachment.obj>


More information about the cfe-commits mailing list