[PATCH] [analyzer] Detect duplicate [super dealloc] calls

David Kilzer ddkilzer at kilzer.net
Sun Sep 7 20:28:36 PDT 2014


> FIXME: This path checker needs to discriminate between different 'self' symbols when recursing into the -dealloc method in the same class (for different objects). See test case.

So I need to test the implicit 'self' argument (for the current method) whenever I encounter a '[super dealloc]' call so I can differentiate the same '[super dealloc]' call for different objects.  I'm not sure whether I should use an `SVal` or a `SymbolRef` (or maybe an `ImplicitParamDecl`) to store the 'self' symbol, though.  Any tips?

I can probably switch to `REGISTER_MAP_WITH_PROGRAMSTATE()` and store the 'self' symbol in there as well.

Note that I posted this patch for review before fixing that bug to address any (early) feedback.

http://reviews.llvm.org/D5238






More information about the cfe-commits mailing list